New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the service is available before record success #92

Open

lukaskupr wants to merge 1 commit into ackintosh:master from lukaskupr:feature/check-availability-before-success

lukaskupr commented Nov 24, 2021

Solve the situation when a request that was sent before the trip may immediately overwrite the success value


          Check the service is available before record success

537c072

ackintosh added the waiting-on-author label

Owner

ackintosh commented Feb 24, 2022

Thank you for your pull request.

I'm not sure this change makes sense because:

As shown at the Usage, users call isAvailable prior to calling success/failure.
It seems impossible to completely avoid the overwrite you mentioned, because the most key-value store does not support ACID transaction. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-author